Skip to content

Commit f701102

Browse files
fix: apply correct styles to audio descriptions track menu items (#8770)
## Description Fix #8769 for mismatched track kind should be plural descriptions according to definition of `AudioTrackKind` #8769 ## Specific Changes proposed Corrects `description` to `descriptions`
1 parent 2b3ffd4 commit f701102

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/css/components/_audio.scss

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,15 @@
22
@extend .vjs-icon-audio;
33
}
44

5-
.video-js .vjs-audio-button + .vjs-menu .vjs-description-menu-item .vjs-menu-item-text .vjs-icon-placeholder,
5+
.video-js .vjs-audio-button + .vjs-menu .vjs-descriptions-menu-item .vjs-menu-item-text .vjs-icon-placeholder,
66
.video-js .vjs-audio-button + .vjs-menu .vjs-main-desc-menu-item .vjs-menu-item-text .vjs-icon-placeholder {
77
vertical-align: middle;
88
display: inline-block;
99
margin-bottom: -0.1em;
1010
}
1111

1212
// Mark a main-desc-menu-item (main + description) or description item with a trailing Audio Description icon
13-
.video-js .vjs-audio-button + .vjs-menu .vjs-description-menu-item .vjs-menu-item-text .vjs-icon-placeholder:before,
13+
.video-js .vjs-audio-button + .vjs-menu .vjs-descriptions-menu-item .vjs-menu-item-text .vjs-icon-placeholder:before,
1414
.video-js .vjs-audio-button + .vjs-menu .vjs-main-desc-menu-item .vjs-menu-item-text .vjs-icon-placeholder:before {
1515
font-family: VideoJS;
1616
content: " \f12e";

src/js/control-bar/audio-track-controls/audio-track-menu-item.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ class AudioTrackMenuItem extends MenuItem {
5151
const el = super.createEl(type, props, attrs);
5252
const parentSpan = el.querySelector('.vjs-menu-item-text');
5353

54-
if (['main-desc', 'description'].indexOf(this.options_.track.kind) >= 0) {
54+
if (['main-desc', 'descriptions'].indexOf(this.options_.track.kind) >= 0) {
5555
parentSpan.appendChild(Dom.createEl('span', {
5656
className: 'vjs-icon-placeholder'
5757
}, {

0 commit comments

Comments
 (0)