Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking apart files #2010

Closed
mmcc opened this issue Apr 3, 2015 · 9 comments
Closed

Breaking apart files #2010

mmcc opened this issue Apr 3, 2015 · 9 comments

Comments

@mmcc
Copy link
Member

mmcc commented Apr 3, 2015

Placeholder for tracking changes related to breaking apart files such as lib and any other file with multiple components within.

@mmcc mmcc added the confirmed label Apr 3, 2015
@mmcc mmcc added this to the v5.0.0 milestone Apr 3, 2015
@mmcc mmcc mentioned this issue Apr 3, 2015
@heff
Copy link
Member

heff commented Apr 3, 2015

I think I can include breaking up the Components in #1993, though it might make it hard to read the specific ES6 Class diffs if a lot of things are in new files.

@heff
Copy link
Member

heff commented Apr 25, 2015

#1993 broke up component classes into their own files. Still need to address lib.

@dmlap
Copy link
Member

dmlap commented Apr 27, 2015

Remaining

  • Break up lib.js into sensible categories
  • Wrap in util.js into that work

@dconnolly
Copy link
Contributor

I can take this.

@heff
Copy link
Member

heff commented May 11, 2015

@dconnolly did you get anywhere with this that I could take a look at? I started taking a pass at this myself.

@heff heff mentioned this issue May 11, 2015
3 tasks
@heff
Copy link
Member

heff commented May 11, 2015

Is there a common way of naming utility library functions when they're pulled into a script individually, so that it's clear they've been pulled in?

For example pulling in createEl from the dom.js util library. I don't love that I might use createEl() somewhere in the code and it looks like any other function that may have been created in that file. Especially in the case of createEl and Component where we're creating a component.createEl() function that uses createEl internally. It gets ambiguous.

ping @gkatsev, @mmcc, @dmlap

@dconnolly
Copy link
Contributor

@heff I did not, spent most of my time on videojs/videojs.com

@heff
Copy link
Member

heff commented May 11, 2015

@dconnolly Cool, no worries. Thanks.

@heff
Copy link
Member

heff commented May 16, 2015

Closed by #2139

@heff heff closed this as completed May 16, 2015
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants