feat: playback rate button now opens the menu rather than changing the playback rate

[misteroneill]

Description

This comes out of discussion in #7121 and its associated PR, #7193.

Currently, in Video.js 7, the PlaybackRateMenuButton will change to the next playback rate when it is clicked, cycling through the list of items. However, this approach has accessibility issues (which were addressed in #7193 as far as I can see) necessitating a workaround.

In Video.js 8, the PlaybackRateMenuButton will behave like other buttons when it is clicked: it will open its associated menu persistently. This is considered a breaking change because it changes the behavior of a control bar menu button.

I'd love to get feedback from @gkatsev and/or @OwenEdwards on whether or not further accessibility updates are warranted here - or if we could potentially remove the workaround introduced in #7193.

Specific Changes proposed

• Remove the handleClick method, which causes us to fall back to MenuButton#handleClick
• Remove the updateARIAAttributes method, which was never called anywhere.
• Add some basic tests because it's the right thing to do!

Requirements Checklist

• Feature implemented / Bug fixed
• If necessary, more likely in a feature request than a bug fix
  • Change has been verified in an actual browser (Chrome, Firefox, IE)
  • Unit Tests updated or fixed
• Reviewed by Two Core Contributors

[codecov]

Codecov Report

Merging #7779 (0c8ac86) into next (337a2a0) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             next    #7779      +/-   ##
==========================================
+ Coverage   81.05%   81.07%   +0.01%     
==========================================
  Files         113      113              
  Lines        7441     7433       -8     
  Branches     1802     1802              
==========================================
- Hits         6031     6026       -5     
+ Misses       1410     1407       -3     

Impacted Files	Coverage Δ
...ar/playback-rate-menu/playback-rate-menu-button.js	100.00% <ø> (+3.70%)	⬆️
src/js/tracks/text-track.js	92.94% <0.00%> (+0.64%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 337a2a0...0c8ac86. Read the comment docs.

[gkatsev]

Seems like it was that easy.
Did a quick test with VoiceOver and seems to work. For whatever reason, VoiceOver is added 1 in front of the actively selected item, both for this and for the captions menu. Probably worth looking at, but it's separate from this PR.