Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove unused type.js file #8658

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

SimonAllen0901
Copy link
Contributor

Description

The type.js file appears to have been added in #8148 but has never been used.
Perhaps it can be removed.

Specific Changes proposed

Remove type.js

Copy link

welcome bot commented Mar 25, 2024

💖 Thanks for opening this pull request! 💖

Things that will help get your PR across the finish line:

  • Run npm run lint -- --errors locally to catch formatting errors earlier.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@mister-ben mister-ben added the needs: LGTM Needs one or more additional approvals label Apr 10, 2024
Copy link
Contributor

@adrums86 adrums86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mister-ben mister-ben merged commit 4ccedc1 into videojs:main Apr 12, 2024
8 of 9 checks passed
Copy link

welcome bot commented Apr 12, 2024

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: LGTM Needs one or more additional approvals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants