Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor error consts #8719

Merged
merged 2 commits into from
May 6, 2024
Merged

feat: refactor error consts #8719

merged 2 commits into from
May 6, 2024

Conversation

adrums86
Copy link
Contributor

@adrums86 adrums86 commented May 3, 2024

Description

Refactor error constants to a generic streaming set.

Specific Changes proposed

Remove unused error constants and replace with generic streaming errors.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.26%. Comparing base (cb76a24) to head (de100f6).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8719      +/-   ##
==========================================
+ Coverage   83.00%   84.26%   +1.25%     
==========================================
  Files         120      120              
  Lines        7998     9197    +1199     
  Branches     1927     2343     +416     
==========================================
+ Hits         6639     7750    +1111     
- Misses       1359     1447      +88     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adrums86 adrums86 merged commit 4dfea61 into main May 6, 2024
14 checks passed
@adrums86 adrums86 deleted the feat-errors branch May 6, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants