fix(types): fix and improve component ready callback definition #8766
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@return {Component}
fromReadyCallback
in Component@this {Component}
fromReadyCallback
in Component, because this is not accurate for classes that extend Component@returns {void}
toReadyCallback
in Component@return
is interpreted by tsc as returning{any}
,@returns {undefined}
would require an explicitreturn undefined
in ts.{PlayerReadyCallback}
in Player with@this {Player}
used in thenew Player()
andvideos()
constructors.player.ready()
which usesReadyCallback
without@this
- but this can't be changed without adding an otherwise unnecessary override just to pander to tsc.Requirements Checklist
npm run docs:api
to error