New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Firefox] Not inject head content #1

Closed

matiaslopezd opened this issue May 15, 2019 · 2 comments

Assignees

Labels

bug

Member

matiaslopezd commented May 15, 2019

In firefox inject all normal in body but in head not.

The text was updated successfully, but these errors were encountered:

matiaslopezd self-assigned this

matiaslopezd added the bug label

Member Author

matiaslopezd commented May 15, 2019 •

edited

Loading

https://github.com/matiaslopezd/iFrameX/blob/a8848372c26955a9d329be6ba1156d949bee300e/src/iframex.js#L77

Fixed error inject undefined content, beacuse not validate if i.content is undefined.

Member Author

matiaslopezd commented May 15, 2019 •

edited

Loading

Finally is fixed.

https://github.com/matiaslopezd/iFrameX/blob/720d64b9ed7b479d1c0582cf56fa14b854829ad2/src/iframex.js#L97
https://github.com/matiaslopezd/iFrameX/blob/720d64b9ed7b479d1c0582cf56fa14b854829ad2/src/iframex.js#L102

Added 1ms timeout in Firefox because need a time for draw DOM of the iframe.

matiaslopezd closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment