Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doesn't work after ejecting #3

Open
dalinarkholin opened this issue Dec 28, 2017 · 3 comments
Open

doesn't work after ejecting #3

dalinarkholin opened this issue Dec 28, 2017 · 3 comments

Comments

@dalinarkholin
Copy link

dalinarkholin commented Dec 28, 2017

Any chance some steps could be put together to get this working after ejecting?

I get a unable to resolve module error. npm start -- --reset-cache does not fix nor the steps the error recommends.

Let me know thanks!

@dariocravero
Copy link

Hey @dalinarkholin, can you share a failing repo? What issues are you seeing? Thanks!

@dariocravero
Copy link

@dalinarkholin, after replying to your message I saw your comment here expo/create-react-native-app#232 (comment). If not linking expo works, perhaps it can be put as a flag in https://github.com/viewstools/yarn-workspaces-cra-crna/blob/master/crna-make-symlinks-for-yarn-workspaces/index.js#L22? Then we would explain on the docs that you can set an option like isExpo: false? Could you do a PR if that works? Thanks!

@cheshirecode
Copy link

Great stuff @dariocravero. Just to follow up that I've got a working setup with ejected RN in https://github.com/cheshirecode/cra-rni-monorepo by uncommenting Expo reference . Definitely needs a flag for https://github.com/viewstools/yarn-workspaces-cra-crna/blob/master/crna-make-symlinks-for-yarn-workspaces/index.js#L22 or link Expo only if it exists as a dependency, not sure what is the best way to handle this. Perhaps we could detect if native package has been ejected or not, hmmm...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants