Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spaces in filenames and paths breaks the pre- and post-commit scripts #109

Closed
DouglasUrner opened this issue Mar 20, 2018 · 6 comments
Closed

Comments

@DouglasUrner
Copy link

The subject pretty much says it all.

I'll see if I can come up with a fix and make a pull request.

@rcasero
Copy link
Collaborator

rcasero commented Mar 21, 2018

Probably all that's needed is to enclose in double quotes ("") path variables, e.g. $SOME_DIR -> "$SOME_DIR"

@code-11
Copy link

code-11 commented Mar 30, 2018

Perhaps you can change IFS=$'\n' and then unset it later? That seemed to work for me.

@yya518
Copy link

yya518 commented Jul 5, 2019

very useful tool! thanks for your contribution. Wish you could fix the filename space issue.

@rcasero
Copy link
Collaborator

rcasero commented Jul 6, 2019

Sorry, @yya518 @code-11 I'm not developing in Matlab anymore. But if you want to try one of the fixes above and send a pull request, I'll check it.

@scfast
Copy link

scfast commented Feb 15, 2020

I've just created a PR for this (#112). I've run it against a few documents with multiple words in the file name (i.e. "my example document.docx")

@rcasero
Copy link
Collaborator

rcasero commented Feb 26, 2020

Thanks, @scfast . I have replied in your PR.

@rcasero rcasero closed this as completed Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants