Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support in Slack DMs or handle error #60

Open
olets opened this issue Jul 9, 2019 · 1 comment
Open

Support in Slack DMs or handle error #60

olets opened this issue Jul 9, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@olets
Copy link
Contributor

olets commented Jul 9, 2019

Currently running /code-review <pr> or /reviews in a Slack DM errors with

{ "error": "channel_not_found" }

 

It'd be cool to support DMs. This is low-priority bells and whistles

@olets olets added the enhancement New feature or request label Jul 9, 2019
@olets olets changed the title Support in Slack DMs Support in Slack DMs or handle error Mar 19, 2020
@olets
Copy link
Contributor Author

olets commented Mar 19, 2020

I think this may not be possible. I've seen a couple similar requests recently where the maintainer's answer has been "slack doesn't support that." Of course now I can't think of where exactly I saw that, so don't have any links to share.

If not possible, would be nice to have a nicer error message. That might not be possible either, if Code Review Bot can't send messages in DMs. But there must be some standard solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant