Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Layout cumulative #85

Closed
brillout opened this issue Jun 13, 2024 · 5 comments
Closed

Make Layout cumulative #85

brillout opened this issue Jun 13, 2024 · 5 comments
Labels
enhancement ✨ New feature or request

Comments

@brillout
Copy link
Member

See:

It's quite a neat change as it enables first-class support nested layouts: https://vike.dev/Layout#nested-layouts.

It's somewhat high priority as the docs already assume Layout to be cumulative.

FYI @Blankeos

@brillout brillout added the enhancement ✨ New feature or request label Jun 13, 2024
@Blankeos
Copy link
Collaborator

Looking great as always @brillout ! Thanks so much for this!

@brillout
Copy link
Member Author

@Blankeos I think I can speak for @magne4000 that contributions are welcome to vike-solid. It's a fairly simple change (see the main commit linked in the PR descriptions).

@Blankeos
Copy link
Collaborator

Yup, I'm working on it actually. Thanks for the links btw.

@magne4000
Copy link
Member

Perfect, I was going to say that I would get this done probably next Tuesday, but yes, contributions are welcome!

@Blankeos
Copy link
Collaborator

Blankeos commented Jun 13, 2024

I spent a good few hours on it, but kinda stuck with SolidJS's tricky hydration and rendering. Don't know how to properly render a dynamic array of wrapper components around props.children.

Let me know if you guys have other ideas. Made the PR here anyway: #86.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants