-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Layout cumulative #85
Comments
Looking great as always @brillout ! Thanks so much for this! |
@Blankeos I think I can speak for @magne4000 that contributions are welcome to |
Yup, I'm working on it actually. Thanks for the links btw. |
Perfect, I was going to say that I would get this done probably next Tuesday, but yes, contributions are welcome! |
I spent a good few hours on it, but kinda stuck with SolidJS's tricky hydration and rendering. Don't know how to properly render a dynamic array of wrapper components around Let me know if you guys have other ideas. Made the PR here anyway: #86. |
See:
It's quite a neat change as it enables first-class support nested layouts: https://vike.dev/Layout#nested-layouts.
It's somewhat high priority as the docs already assume
Layout
to be cumulative.FYI @Blankeos
The text was updated successfully, but these errors were encountered: