Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ?extractAssets workaround in favor of build.ssrEmitAssets #1339

Closed
brillout opened this issue Dec 9, 2023 · 1 comment
Closed

Remove ?extractAssets workaround in favor of build.ssrEmitAssets #1339

brillout opened this issue Dec 9, 2023 · 1 comment
Labels
contribution-welcome 💕 enhancement ✨ New feature or request

Comments

@brillout
Copy link
Member

brillout commented Dec 9, 2023

Description

The code for the ?extractAssets workaround is non-trivial and brittle. (See https://vike.dev/includeAssetsImportedByServer for why the workaround is needed.)

It would be more robust to use build.ssrEmitAssets instead. (There is actually an issues with a Babel plugin.)

See also:
@brillout brillout mentioned this issue Dec 18, 2023
Merged
@brillout
Copy link
Member Author

brillout commented Feb 7, 2024

Implemented by #1364.

@brillout brillout closed this as completed Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contribution-welcome 💕 enhancement ✨ New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brillout