-
-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New CLI command $ vike eject
#1553
Comments
This would be massive in terms of the company project we're considering |
@tbjgolden How so? |
Optional control is something we care about - we'd obviously prefer to trust a preset that others also use but if needs must we'd be able to maintain some custom code Nothing specific in mind, more of a insurance policy that makes it easier to get sign off on it |
Yes, that‘s the idea. In the meantime you can manually eject. |
@tbjgolden Also btw. in case that's something your company would be up for, Vike is looking for sponsors. (As a bonus Vike could then, for example, prioritize eject.) |
Another use case I can think of is when a user may want to eject specific files, like For example
Edit
|
I'm not sure that would work, unless every imported module(in the ejected files) are (re)exported from |
Yeah, I think you're right. I've updated my comment. Here is an example vike-react-styled-components-grommet by @lourot |
I worked on this here - #1798 |
I just wanted to pop in here and let you guys now that development moved into its own repository. We just released a first version. See docs and repository. |
I guess we can mark this as completed. Props to @snake-py 💯 |
Description
Make Vike integrations ejectable.
For example
$ vike eject vike-react-apollo
would essentially do two things:node_modules/vike-react-apollo/
to the user-landpages/
. (Or better yet its TypeScript source code.)vike-react-apollo
frompackage.json#dependencies
.Eject is also nice from a marketing perspecitve as it doubles down on the Optional Control USP.
WIP: #1798
Prior art: https://github.com/brillout/eject
The text was updated successfully, but these errors were encountered: