Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is the viewmodel scope should not be activity ? #1

Open
afaucogney opened this issue Nov 8, 2017 · 1 comment
Open

is the viewmodel scope should not be activity ? #1

afaucogney opened this issue Nov 8, 2017 · 1 comment

Comments

@afaucogney
Copy link

@villela Thank for this, because it help me a lot going further with integration of TP with VM
However do you think application scope the good level ?

@villela
Copy link
Owner

villela commented Nov 8, 2017

I'm glad commiting this helped someone, good to hear.

Well, I'm not sure about anything here. From what I've seen using a root scope my ViewModels worked as expected.

Probably the root scope is not the best option but using the activity scope instead for sure isn't a correct approach since multiple activities should be able to attach to the same ViewModel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants