-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Player unusable after error at instantiation #166
Comments
Also running into this problem, are there any known workarounds until this gets solved? Edit: I can't even seem to create a new player instance, does it use some sort of global cache? Edit 2: It seems the faulty players -are- in fact cached, even when it hits this "deadlock" failure state. See my comment below. |
After looking into this I see that the This poses a problem if you're trying to reuse the element inside for example React. Perhaps if the instantiation fails we should undo any created side-effects (in effect removing the cached element from the @luwes @bdougherty Thoughts? |
When loading an invalid clip the ready promise will now reject and in turn all getters, setters and methods as well. |
Maybe related to #165
Expected Behavior
The player should be able to call all its methods after instantiating a bad player, but their promises should all be caught.
Actual Behavior
Promises are never fullfilled.
Steps to Reproduce
Codepen
Possible source
callMethod
in player.js. It only tries to do its stuff when the player is ready, but if it never started out ready, then it just won't do anything.The text was updated successfully, but these errors were encountered: