urlencode(non-empty-string) returns non-empty-string

[mathroc]

Hi!

is it ok to update the callmap to make Psalm understand that urlencode(non-empty-string) will always return a non-empty-string ?

I guess there are many over functions like that and I'm not planning to do all of them though 😅

[psalm-github-bot]

Hey @mathroc, can you reproduce the issue on https://psalm.dev? These will be used as phpunit tests when implementing the feature or fixing this bug.

[mathroc]

https://psalm.dev/r/b603b51a2c

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/b603b51a2c

<?php

/**
 * @param non-empty-string $input
 * @return non-empty-string
 */
function f(string $input): string
{
    return urlencode($input);
}

Psalm output (using commit a9b5291):

INFO: LessSpecificReturnStatement - 9:12 - The type 'string' is more general than the declared return type 'non-empty-string' for f

INFO: MoreSpecificReturnType - 5:12 - The declared return type 'non-empty-string' for f is more specific than the inferred return type 'string'