Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Which is the status of autocomplete feature for LSP? #4942

Closed
juanrgm opened this issue Jan 7, 2021 · 3 comments
Closed

Which is the status of autocomplete feature for LSP? #4942

juanrgm opened this issue Jan 7, 2021 · 3 comments

Comments

@juanrgm
Copy link

juanrgm commented Jan 7, 2021

The documentation says:

It currently supports diagnostics (i.e. finding errors and warnings), go-to-definition and hover.

And there is not mentions to autocomplete feature but it works partially, at least for me. So what is the status for autocomplete feature?

I did some tests and it does not work with functions/use className, and the CoreGenericFunctions.phpstub does not include the descriptions in the docblocks. I also found other cases like this (#2318).

It may be interesting to specify the LSP features supported (https://microsoft.github.io/language-server-protocol/specifications/specification-current/) to avoid confusions and appeal to the developers to collaborate with this project (including me).

Currenty there is not a full PHP support for VSCode and this project has all the potential for it.

@muglug
Copy link
Collaborator

muglug commented Jan 7, 2021

There's partial support – and I've just updated the documentation.

LSP autocomplete support in Psalm is not a feature I'm going to spend much time on as it's a pretty complex area and Psalm has more pressing features & issues.

If you're looking for better autocomplete support I welcome PRs, but there are also tools like Intelephense that have more LSP features, and also a paid plan.

@muglug muglug closed this as completed Jan 7, 2021
@juanrgm
Copy link
Author

juanrgm commented Jan 7, 2021

The problem with Intelephense is that the source code of LSP server is private and there is not support for advanced features like @template (bmewburn/vscode-intelephense#1144) or array shapes.

It is for that reason that I am searching alternatives but no luck.

@muglug
Copy link
Collaborator

muglug commented Jan 11, 2021

The only thing holding back Psalm's LSP support is that nobody's working on it. I'd be very happy for someone to work on more completion features, but that sort of work is well outside what most PHP developers do day-to-day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants