Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is findUnusedCode default to true now? #5714

Closed
DavideBicego opened this issue May 4, 2021 · 7 comments
Closed

Is findUnusedCode default to true now? #5714

DavideBicego opened this issue May 4, 2021 · 7 comments

Comments

@DavideBicego
Copy link

I'm updating to 4.7.2 from 4.4.1 and I have some issues regarding UnusedMethodCall.

It seems to me that the default value for findUnusedCode in this version is set to true.
Is this the wanted behavior?

@psalm-github-bot
Copy link

Hey @DavideBicego, can you reproduce the issue on https://psalm.dev ?

@weirdan
Copy link
Collaborator

weirdan commented May 4, 2021

Should be still false. Can you provide a reproducer, in a separate repo?

@DavideBicego
Copy link
Author

@weirdan
Copy link
Collaborator

weirdan commented May 5, 2021

Confirmed locally, thanks.

@weirdan
Copy link
Collaborator

weirdan commented May 5, 2021

Well, that's intentional, see release notes for https://github.com/vimeo/psalm/releases/tag/4.7.0

@weirdan weirdan removed the bug label May 5, 2021
@DavideBicego
Copy link
Author

Oh ok... This is really a pain when using Webmozart Assert all() to assert that an array contains just values of some type.

Thanks anyway!

@Ocramius
Copy link
Contributor

Ocramius commented May 6, 2021

This has been solved in webmozart/assert through webmozarts/assert#214

It was originally tracked by #4381

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants