Redundant range checks for typed ints

[weirdan]

https://psalm.dev/r/a7b57656ec

Both asserts should be redundant, as the property is typed, and thus the value is always PHP_INT_MIN <= $value <= PHP_INT_MAX

Refs #9499 (comment)

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/a7b57656ec

<?php
class C {
    public int $i = 0;
}

function f(C $c): void {
    assert($c->i <= PHP_INT_MAX);
    assert($c->i >= PHP_INT_MIN);
}

Psalm output (using commit 9b00049):

No issues!

[weirdan]

Ideally we should also catch this: https://psalm.dev/r/2bbda08bb8

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/2bbda08bb8

<?php
class C {
    public int $i = 0;
}

function f(C $c): void {
    $i = $c->i;
    assert($i <= PHP_INT_MAX);
    assert($i >= PHP_INT_MIN);
}

Psalm output (using commit 9b00049):

No issues!