Skip to content

Commit e693dcf

Browse files
committed
Prepare for Sidekiq v4.0.0
1 parent fc51ed7 commit e693dcf

File tree

6 files changed

+5
-19
lines changed

6 files changed

+5
-19
lines changed

.gitignore

+1
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,3 @@
11
Gemfile.lock
22
pkg/
3+
.bundle/

Gemfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
source 'https://rubygems.org'
22
gemspec
33

4-
gem 'sidekiq', github: 'mperham/sidekiq'
4+
gem 'sidekiq', github: 'mperham/sidekiq', branch: 'internal_rewrite'

lib/sidekiq/limit_fetch.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ def retrieve_work
3434
private
3535

3636
def fetch_message
37-
queue, _ = redis_brpop *@queues.acquire, Sidekiq::Fetcher::TIMEOUT
37+
queue, _ = redis_brpop *@queues.acquire, Sidekiq::BasicFetch::TIMEOUT
3838
ensure
3939
@queues.release_except queue
4040
end

lib/sidekiq/limit_fetch/redis.rb

+1-15
Original file line numberDiff line numberDiff line change
@@ -3,21 +3,7 @@ module Sidekiq::LimitFetch::Redis
33

44
def nonblocking_redis
55
redis do |redis|
6-
# Celluloid 0.16 broke this method
7-
if Celluloid::VERSION.to_f >= 0.16
8-
yield redis
9-
else
10-
# prevent blocking of fetcher
11-
# more bullet-proof and faster (O_O)
12-
# than using Celluloid::IO
13-
#
14-
# https://github.com/brainopia/sidekiq-limit_fetch/issues/41
15-
# explanation of why Future#value is beneficial here
16-
begin
17-
Celluloid::Future.new { yield redis }.value
18-
rescue Celluloid::Task::TerminatedError
19-
end
20-
end
6+
yield redis
217
end
228
end
239

sidekiq-limit_fetch.gemspec

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ Gem::Specification.new do |gem|
1515
gem.test_files = gem.files.grep %r{^spec/}
1616
gem.require_paths = %w(lib)
1717

18-
gem.add_dependency 'sidekiq', '>= 2.6.5', '< 4.0'
18+
gem.add_dependency 'sidekiq', '~> 4.0.0'
1919
gem.add_development_dependency 'rspec', '~> 3.2.0'
2020
gem.add_development_dependency 'rake'
2121
end

spec/spec_helper.rb

-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
require 'sidekiq/limit_fetch'
2-
require 'celluloid/autostart'
32
require 'sidekiq/fetch'
43

54
Sidekiq.logger = nil

0 commit comments

Comments
 (0)