Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul Native Module/ViewManager Decorators #9

Closed
vincentriemer opened this issue Mar 28, 2018 · 1 comment
Closed

Overhaul Native Module/ViewManager Decorators #9

vincentriemer opened this issue Mar 28, 2018 · 1 comment

Comments

@vincentriemer
Copy link
Owner

vincentriemer commented Mar 28, 2018

Blocked by babel/babel#7542, facebook/metro#92

Currently the decorators used for exposing modules/methods/view properties are utilizing the deprecated decorators babel transform and should be migrated to the spec and the new transform. This should be an opportunity to revisit the actual naming and functionality of the decorators, for example add commonly used value transformations like view style props that accept colors (need to convert from number to rgba values)

@vincentriemer
Copy link
Owner Author

Since Babel still hasn't added support for the new decorator spec and has all but broken the legacy decorator transform in Babel 7, I decided to migrate away from decorators altogether, and the new way of binding to native modules will be available in the next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant