-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to use sets of families for the BicopFamily class #63
Comments
Ah.. We should clarify this in the documentation. Also, wouldn't it be better to have this as |
Agreed for the clarifications. Regarding the namespace, I'm not sure that it's worth it. If anything, I would actually have |
I see, OK and then this is set by passing e.g.
Thanks for the clarification. |
Wouldn't it be confusing (if at all possible) to have an enum that holds a list of enums of the same type? |
@dmey exactly! However, |
@tnagler The enum would'nt "hold" the list, it would just have a method allowing to create such a list. |
Since the doc has been corrected for a while, I'm closing. Feel free to reopen if needed. |
Actually, arguments of the controls should be better documented anyway. I'm reopening. |
Perhaps related, is there a way to specify the family for each bicop and then fit them to data? Do I have to fit each bicop separately then? If so, does the bicop.fit() just take the leftmost columns in the dataset? For instance, I'd like to set up:
then
but now
can change families and
can make some bb7 and some indep, |
@kevindarby Since last release, we now have a fit method, so it is indeed possible. See Vinecop.fit. I'm closing but feel free to reopen if this does not solve your issue. |
I tried to set the controls for a set of family rather than its members as mentioned in the docs (https://vinecopulib.github.io/pyvinecopulib/_generate/pyvinecopulib.BicopFamily.html#pyvinecopulib.BicopFamily) as:
however these families are not members of the BicopFamily and result in
AttributeError: type object 'pyvinecopulib.BicopFamily' has no attribute 'all'
. Is this meant to be called in a different way?The text was updated successfully, but these errors were encountered: