bauh Crashes When Trying to Update an AppImage

[lfom]

Before opening a new issue
Done, same error as latest release (0.9.21)

Describe the bug
bauh "keeps processing forever" when updating an AppImage manually right after selecting the new version and clicking on Proceed. The app does not hang tho, it can be closed. It used to work before but I am not sure when it broke. =(
When using the stagging version, it crashes as shown below.

Log from release version:

$ bauh
Warning: Ignoring XDG_SESSION_TYPE=wayland on Gnome. Use QT_QPA_PLATFORM=wayland to run on Wayland anyway.
qt.qpa.xcb: QXcbConnection: XCB error: 5 (BadAtom), sequence: 513, resource id: 0, major code: 20 (GetProperty), minor code: 0
Traceback (most recent call last):
  File "/home/lfom/.local/lib/python3.9/site-packages/bauh/view/qt/thread.py", line 1041, in run
    res['success'] = self.manager.execute_custom_action(action=self.custom_action,
  File "/home/lfom/.local/lib/python3.9/site-packages/bauh/view/core/controller.py", line 509, in execute_custom_action
    return eval(f"man.{action.manager_method}({'pkg=pkg, ' if pkg else ''}root_password=root_password, watcher=watcher)")
  File "<string>", line 1, in <module>
  File "/home/lfom/.local/lib/python3.9/site-packages/bauh/gems/appimage/controller.py", line 179, in update_file
    return self.upgrade(reqs, root_password=root_password, watcher=watcher)
  File "/home/lfom/.local/lib/python3.9/site-packages/bauh/gems/appimage/controller.py", line 367, in upgrade
    download_data = self._download(req.pkg, watcher)
  File "/home/lfom/.local/lib/python3.9/site-packages/bauh/gems/appimage/controller.py", line 515, in _download
    file_name = appimage_url.split('/')[-1]
AttributeError: 'NoneType' object has no attribute 'split'

Log from staging:

$ venv/bin/bauh
Traceback (most recent call last):
  File "/home/lfom/Playground/bauh/venv/lib/python3.9/site-packages/bauh/view/qt/thread.py", line 1041, in run
    res['success'] = self.manager.execute_custom_action(action=self.custom_action,
  File "/home/lfom/Playground/bauh/venv/lib/python3.9/site-packages/bauh/view/core/controller.py", line 508, in execute_custom_action
    return eval(f"man.{action.manager_method}({'pkg=pkg, ' if pkg else ''}root_password=root_password, watcher=watcher)")
  File "<string>", line 1, in <module>
  File "/home/lfom/Playground/bauh/venv/lib/python3.9/site-packages/bauh/gems/appimage/controller.py", line 179, in update_file
    return self.upgrade(reqs, root_password=root_password, watcher=watcher)
  File "/home/lfom/Playground/bauh/venv/lib/python3.9/site-packages/bauh/gems/appimage/controller.py", line 367, in upgrade
    download_data = self._download(req.pkg, watcher)
  File "/home/lfom/Playground/bauh/venv/lib/python3.9/site-packages/bauh/gems/appimage/controller.py", line 515, in _download
    file_name = appimage_url.split('/')[-1]
AttributeError: 'NoneType' object has no attribute 'split'
Fatal Python error: Aborted

Current thread 0x00007f41e4f0d640 (most recent call first):
<no Python frame>

Thread 0x00007f41fc87c640 (most recent call first):
  File "/home/lfom/Playground/bauh/venv/lib/python3.9/site-packages/bauh/view/qt/thread.py", line 822 in run

Thread 0x00007f41e77fe640 (most recent call first):
  File "/home/lfom/Playground/bauh/venv/lib/python3.9/site-packages/bauh/view/qt/thread.py", line 822 in run

Thread 0x00007f41fd87e640 (most recent call first):
  File "/home/lfom/Playground/bauh/venv/lib/python3.9/site-packages/bauh/view/qt/prepare.py", line 140 in run

Thread 0x00007f41fe07f640 (most recent call first):
  File "/home/lfom/Playground/bauh/venv/lib/python3.9/site-packages/bauh/view/util/cache.py", line 96 in run
  File "/usr/lib/python3.9/threading.py", line 954 in _bootstrap_inner
  File "/usr/lib/python3.9/threading.py", line 912 in _bootstrap

Thread 0x00007f4234fd9740 (most recent call first):
  File "/home/lfom/Playground/bauh/venv/lib/python3.9/site-packages/bauh/app.py", line 54 in main
  File "/home/lfom/Playground/bauh/venv/bin/bauh", line 33 in <module>
[1]    49331 IOT instruction (core dumped)  venv/bin/bauh

Software Environment
bauh version: 0.9.21
O.S: Pop!_OS 21.04 (like Ubuntu 21.04)
Python version: 3.9.5
Installation method: pip

[vinifmor]

@lfom Another user had the same issue last week, and it ended up that the problem was on the database. Some apps had incomplete data. The problem was already solved (on the back-end side), but your local app installation probably has missing data.

Try this:

1. reinstall the app
2. downgrade it
3. update again

Anyway, I'm going to add an additional handling on client side based on this error stack.

[lfom]

@vinifmor You mean the installed app that is being updated has incomplete data? This is the version that was already installed, and updating it worked in the past:

Anyway, probably it easier (and safer) to import the newer one and delete the older one?

[vinifmor]

Hum... the scenario I've described was related to apps from the database. I'm going to try with imported apps.

[vinifmor]

@lfom issue already fixed on the staging branch. It is a regression introduced in 0.9.21.

[lfom]

@vinifmor Confirmed working on staging (0.9.22).
Once again, thank you for the app and maintaining it!
Regards

[vinifmor]

No worries. Thanks for reporting the problem.