Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display cookies based on the filter i.e. regex(say *.github.com) #3

Open
vinitshahdeo opened this issue Oct 1, 2019 · 6 comments
Open

Display cookies based on the filter i.e. regex(say *.github.com) #3

vinitshahdeo opened this issue Oct 1, 2019 · 6 comments
Labels
enhancement New feature or request hacktoberfest help wanted Extra attention is needed up-for-grabs Solve the issue and raise your first PR

Comments

@vinitshahdeo
Copy link
Owner

Send PR with the changes to filter cookies based on regex.

Note - Please make changes in CSS.
@vinitshahdeo vinitshahdeo added help wanted Extra attention is needed hacktoberfest enhancement New feature or request labels Oct 1, 2019
@vinitshahdeo vinitshahdeo added the up-for-grabs Solve the issue and raise your first PR label Oct 4, 2019
@bhargava-raju
Copy link

Is this closed or still open to be worked

@vinitshahdeo
Copy link
Owner Author

@bhargava-raju No PRs yet for this issue. Please go ahead.

@bhargava-raju
Copy link

Working on it, will raise PR as soon as I finish. Thanks..!

@bhargava-raju
Copy link

Should it be implemented in such way that it supports displaying of multiple domain cookies based on the regex filter. If yes, should it first make selection of a particular domain and only display those cookies pertaining to that domain. This would also demand major changes to the UI. Please share your thoughts on this

@bhargava-raju
Copy link

A filter has been applied to domain field to match all the domain names provided in the field control along with their respective cookies.

An additional column can be found in the cookies displayed table header "DOMAIN". Also increased the length of the table cell to 20 & 25 for better readability.

These changes have been made without touching the other operations.

See the below screenshot:
image

@vinitshahdeo
Copy link
Owner Author

@bhargava-raju That's awesome!
I'll review and merge it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request hacktoberfest help wanted Extra attention is needed up-for-grabs Solve the issue and raise your first PR
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vinitshahdeo @bhargava-raju