Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check Java and Rustup versions on startup #35

Open
fpoli opened this issue Jan 12, 2021 · 6 comments
Open

Check Java and Rustup versions on startup #35

fpoli opened this issue Jan 12, 2021 · 6 comments
Labels
enhancement New feature or request good-first-issue Good for newcomers

Comments

@fpoli
Copy link
Member

fpoli commented Jan 12, 2021

As described in the readme, the extension currently requires Java >=12 Java >=11 and Rustup >=1.23. It would be useful to check these versions at startup, as part of the prerequisite checks, reporting an useful error message in case Java/Rustup is not up to date.

Feel free to ask for more information if you are interested in working on this!

@fpoli fpoli added enhancement New feature or request good-first-issue Good for newcomers labels Jan 12, 2021
@fpoli fpoli changed the title Check Java and Rustup version on startup Check Java and Rustup versions on startup Jan 12, 2021
@Aurel300
Copy link
Member

I think the requirement is >= 11? That is what I am running locally.

@fpoli
Copy link
Member Author

fpoli commented Jan 13, 2021

I think the requirement is >= 11? That is what I am running locally.

Oh, you are right! The class file version 55.0 corresponds to Java 11, not 12.

@quinn-dougherty
Copy link

should also be able to configure exactly which rustup and javac bins ought to be used.

@fpoli
Copy link
Member Author

fpoli commented Jan 17, 2024

The javac to be used should already be configurable with this setting:

Prusti-assistant: Java Home
Specifies the path of the Java home folder (leave empty to auto-detect).

We could do something similar with rustup. What's your use case? Do you have multiple rustup binaries or is it just not in your program path?

@quinn-dougherty
Copy link

I would like prusti to be sensitive to direnv (i tried fiddling a little with the vscode direnv options). I currently need a user-wide installation of rustup in order for prusti to work, which completely breaks my rust-analyzer config elsewhere, since usually direnv is what works.

@fpoli
Copy link
Member Author

fpoli commented Jan 22, 2024

I opened an issue to make rustup's path configurable: #246

I don't have much spare time these days, but I'd be happy to review and merge any contribution :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good-first-issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants