Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply the RFC7516 standard to the Response structure #47

Closed
Xynnn007 opened this issue Dec 2, 2024 · 0 comments · Fixed by #48
Closed

Apply the RFC7516 standard to the Response structure #47

Xynnn007 opened this issue Dec 2, 2024 · 0 comments · Fixed by #48

Comments

@Xynnn007
Copy link
Contributor

Xynnn007 commented Dec 2, 2024

We had found that KBS Protocol does not follow JWE standard quite well, and we had done some work to fix this up.

#44
#45

The two patches add support to AEAD's aad field to JWE body, and also a format for ProtectedHeader.

When I rechecked the standard, I found that there are still some pieces we do not follow quite well.

  1. The ProtectedHeader must be a base64 encoding string of the struct.
  2. When serializing the Response in Flattened JWE JSON Serialization Syntax, fields encrypted_key, aad, iv, ciphertext, tag must be BASE64URL_NOPAD encoded.

I am sorry that the previous commits from my side did not fix the things perfectly. Thus I put this issue to catch some attention if anything is missed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant