stream shall be created only once during prepare

[MatiasVara]

Stream shall be created only during transiting from SET_PARAM to PREPARE in the prepare() cmd. Otherwise, we are creating several streams, each time guest triggers the prepare() cmd. See

vhost-device/crates/sound/src/audio_backends/pw_backend.rs

Line 275 in d2757ae

let mut stream = pw::stream::Stream::<i32>::new(

[dorindabassey]

I thought that the best approach was to add a pw_stream_destroy bindings, because using a Drop impl makes the stream destroy itself automatically as soon as the first one is dropped, even though the "real" Stream wrapper is still being used, but that's apparently not the best approach aswell, Since adding the pw_stream_destroy bindings results in some segfault. The other workaround would have been to create the stream on the condition that the stream has not been created yet, But the condition blocks the usage of stream in the stream_listener.

[MatiasVara]

The other workaround would have been to create the stream on the condition that the stream has not been created yet, But the condition blocks the usage of stream in the stream_listener.

Could you elaborate on this?

[MatiasVara]

I close this issue since this is tracked at #43.