Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Update LayerExtension examples to include return of a well defined shader module #9127

Open
richard3d opened this issue Aug 31, 2024 · 0 comments
Labels

Comments

@richard3d
Copy link

richard3d commented Aug 31, 2024

Link

https://deck.gl/docs/developer-guide/custom-layers/layer-extensions#example-layer-extension

Description

See #9122 for the origination of this suggestion. The LayerExtension dev-guide page does not provide very clear guidance on the shape of a shader module to be returned from getShaders() which can affect if an extension is properly merged with a layer's shader code as in the original problem. The examples are too minimal to provide insight as well. Another acceptable/appropriate location to mention this information might be in the writing-shaders.

@richard3d richard3d added the doc label Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant