Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ParquetLoader ERRORS #3041

Closed
aycaramba1224 opened this issue Jul 1, 2024 Discussed in #3040 · 8 comments · Fixed by #3079
Closed

ParquetLoader ERRORS #3041

aycaramba1224 opened this issue Jul 1, 2024 Discussed in #3040 · 8 comments · Fixed by #3079

Comments

@aycaramba1224
Copy link

Discussed in #3040

@Beiusxzw
Copy link

Beiusxzw commented Jul 9, 2024

I also encountered this. How should I fix this issue?

@aycaramba1224
Copy link
Author

I can't fix it.

@belom88 belom88 linked a pull request Sep 5, 2024 that will close this issue
@belom88
Copy link
Collaborator

belom88 commented Sep 5, 2024

parquet-loader-worker.js is not built because of CommonJS relationships in code.
As a temporary solution you can set worker: false option:

  const result = load(data, ParquetLoader, {worker: false})

@shaunakv1
Copy link

shaunakv1 commented Oct 7, 2024

@belom88 @ibgreen
Performance is taking a serious hit when worker is turned to false for me. Is there anyway to get a pre-compiled parquet-loader-worker.js temporarily? Or will this ever be fixed in the code?

@ibgreen
Copy link
Collaborator

ibgreen commented Oct 7, 2024

@shaunakv1

Performance is taking a serious hit when worker is turned to false for me.

Hmm, was the JavaScript parquet worker loader ever functional? Even if it was, hard to see how it would be faster.
Or is this just a statement that perf is not a good enough using the default JavaScript based loader?

The path to good performance for Parquet is to use the WASM library via ParquetWASMLoader. That is where effort is being put for now.

@ibgreen
Copy link
Collaborator

ibgreen commented Oct 7, 2024

For repo hygiene reasons, we don't discuss in closed tickets. Please open a GitHub discussion if there is more to discuss.

@shaunakv1
Copy link

thanks for the response @ibgreen .

Is there any documentation on ParquetWASMLoader that I can refer to? I am not seeing it in the list of loaders at

https://loaders.gl/docs/modules/parquet/api-reference/parquet-loader

Also will I still be able to use it with Deck.gl?

@ibgreen
Copy link
Collaborator

ibgreen commented Oct 7, 2024

As I said, further conversation in the discussions tab, please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants