build_visit failure on RZ related to pygments

[JustinPrivitera]

build_visit invocation on the develop branch as of 02/01 morning (after 20b72c0):

./build_visit --makeflags -j24 --mesagl --mpich --no-gdal --required --optional --qt6

Cmd line error:

Building VisIt (~50 minutes)
Building VisIt in visit/build . . .
Configuring VisIt . . .
Building VisIt . . . (~50 minutes)
Building the VisIt manuals failed. Continuing
All indications are that VisIt was successfully built.
Packaging VisIt ... (~10 minutes)
VisIt package failed. Giving up
Unable to build or install VisIt. Bailing out.
Error in build process. See build_visit_log for more information. If the error is unclear, please include build_visit_log and contact the VisIt project via https://visit-help.llnl.gov. You may need to compress the build_visit_log using a program like gzip so it will fit within the size limits for attachments.
Log file full path:  /usr/workspace/justin/visit_builds/develop-w-tpls/build_visit_log

From the log:

gmake[1]: warning: jobserver unavailable: using -j1.  Add '+' to parent make rule.
Traceback (most recent call last):
  File "/usr/workspace/justin/visit_builds/develop-w-tpls/third_party/python/3.9.18/linux-x86_64_gcc-10.3/bin/sphinx-build", line 5, in <module>
    from sphinx.cmd.build import main
  File "/usr/workspace/justin/visit_builds/develop-w-tpls/third_party/python/3.9.18/linux-x86_64_gcc-10.3/lib/python3.9/site-packages/sphinx/cmd/build.py", line 20, in <module>
    from sphinx.application import Sphinx
  File "/usr/workspace/justin/visit_builds/develop-w-tpls/third_party/python/3.9.18/linux-x86_64_gcc-10.3/lib/python3.9/site-packages/sphinx/application.py", line 21, in <module>
    from pygments.lexer import Lexer
ModuleNotFoundError: No module named 'pygments'
make[4]: *** [doc/CMakeFiles/manuals.dir/build.make:70: doc/CMakeFiles/manuals] Error 1
make[3]: *** [CMakeFiles/Makefile2:88735: doc/CMakeFiles/manuals.dir/all] Error 2
make[2]: *** [CMakeFiles/Makefile2:88742: doc/CMakeFiles/manuals.dir/rule] Error 2
gmake[1]: *** [Makefile:187: doc/CMakeFiles/manuals.dir/rule] Error 2
CMake Error at /usr/workspace/justin/visit_builds/develop-w-tpls/visit/build/doc/cmake_install.cmake:51 (file):
  file INSTALL cannot find
  "/usr/workspace/justin/visit_builds/develop-w-tpls/visit/build/resources/help/en_US/manual":
  No such file or directory.
Call Stack (most recent call first):
  /usr/workspace/justin/visit_builds/develop-w-tpls/visit/build/cmake_install.cmake:2692 (include)


CPack Error: Error when generating package: visit
make: *** [Makefile:71: package] Error 1

[biagas]

I saw the same thing on pascal, discovered pygments, applehelp and html help didn't get installed.
Had to reduce the 'pip install' command to the following to get it to work for those packages.

python3 -m pip install –no-deps

[cyrush]

I wonder if this is related to: #19279

[biagas]

Here's the messages when you build pygments with the current bv_python.sh and it's arguments to pip install:

pascal83{kbonnell}:../third_party/python/3.9.18/linux-x86_64_gcc-10.3/bin/python3 -m pip --no-cache-dir --disable-pip-version-check install --no-index --no-deps --no-build-isolation .
Processing /usr/WS1/kbonnell/BuildVisIt/3.4.1/Pygments-2.15.1
  Preparing metadata (pyproject.toml) ... done
Building wheels for collected packages: UNKNOWN
  Building wheel for UNKNOWN (pyproject.toml) ... done
  Created wheel for UNKNOWN: filename=UNKNOWN-0.0.0-py3-none-any.whl size=6698 sha256=35e02841eb6a31eaf4ac83af918b98a9739ed4a6998124abaa2ead19ceb511db
  Stored in directory: /tmp/kbonnell/pip-ephem-wheel-cache-8pxgbkvr/wheels/e9/96/ed/eb459de6ab8430acc65b9c96990ed5b0f256a747c1c965131f
Successfully built UNKNOWN
Installing collected packages: UNKNOWN
  Attempting uninstall: UNKNOWN
    Found existing installation: UNKNOWN 0.0.0
    Uninstalling UNKNOWN-0.0.0:
      Successfully uninstalled UNKNOWN-0.0.0
Successfully installed UNKNOWN-0.0.0
pascal83{kbonnell}:

So there is no Pygments in the site-packages of the python install, there is UNKNOWN instead.
This also happens for sphinxcontrib-applehelp-1.0.4 and sphinxcontrib-htmlhelp-2.0.11

[JustinPrivitera]

I am still seeing this error on the latest version of the RC (as of 02/12/24).

[markcmiller86]

I am still seeing this error on the latest version of the RC (as of 02/12/24).

Me too. I thought it was because I had an issue in numpy install and restarted the install in the middle of python world magic.

[biagas]

Tried google, came across this:
pypa/setuptools#3269

Seems a problem with setuptools? but bv_python no longer installs ?

Pygment's pyproject.toml says it requires setuptools:

[build-system]
# setuptools added pyproject.toml support in v61.0.0
requires = ["setuptools >= 61"]

I ran python3 -m pip debug from a build of python 3.9.18 I did locally, and setuptools information from pip was:

 setuptools==44.0.0 (Unable to locate actual module version, using vendor.txt specified version)

I can try adding setuptools to bv_python and see if it resolves this problem.

[cyrush]

sorry - sounds like another error due to too many moving pieces.

We should add setuptools back.

[biagas]

I saw a setuptools version 58 in the python site-packages, But that isn't new enough for Pygments.
Pillow's requirement is newer, 67.8, so I will try that one.

[cyrush]

@biagas

We should install setuptools at the start, right around where we install wheel

visit/src/tools/dev/scripts/bv_support/bv_python.sh

Line 1585 in 17511b9

check_if_py_module_installed "wheel"

[biagas]

Is there a way to test if a specific version of a module is installed?
I added setuptools before wheel, but 58.0 version is already installed so
check_if_py_module_installed "setuptools" inidicates already installed, and 67.8 doesn't get installed.

[cyrush]

ahh -- python has a built in version, maybe we should move the logic for setuptools to where we compile/install python itself and skip the version check since its more of a special case.

[biagas]

setuptools requires wheel, so needs to come after that. I can simply remove the install check, unless you think wheel should also be put into build_python function (?)

[cyrush]

we can move wheel there as well. without them both we don't have a solid setup to install other modules

[biagas]

How do the modules without URL's get downloaded?
setuptools isn't getting downloaded, I have to do it manually.

[biagas]

FYI, I did manage to confirm that installing setuptools 67.8.0 as part of bv_python fixes the installation problems with Pygments, sphinxcontrib-applehelp and sphincontrib-htmlhelp.

[cyrush]

they should all be reaching back to our copy in github in the visit thirdpary repo.

[biagas]

they should all be reaching back to our copy in github in the visit thirdpary repo.

Aha. I haven't added setuptools there yet, so makes sense.

[JustinPrivitera]

I'm putting this in 3.4.1 since I cannot build VisIt at all on LC.