Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add functionality from CHAP links.Network package #70

Open
clemarcou opened this issue Jul 18, 2019 · 3 comments
Open

add functionality from CHAP links.Network package #70

clemarcou opened this issue Jul 18, 2019 · 3 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@clemarcou
Copy link

clemarcou commented Jul 18, 2019

Why no replacement to Package from CHAP links.Network ?

  1. I upgraded my project to vis.js but there is no feature to illustrate communication between the nodes. Was there any specific reason to not keep Package from CHAP ?

  2. I'm planning to implement a replacement for it for myself locally, do you have any advice or warning on how to do it ? (especially if answer to 1) is "Yes)

  3. Would it be relevant to integrate such a feature into vis.js ?

@micahstubbs
Copy link
Member

hi @clemarcou, thanks for for the questions. I'll do my best to answer 😄

  1. great question. This piece of history project history was before my time. Perhaps some of other contributors know the answer? https://almende.github.io/chap-links-library/

  2. No general advice now, other than please do send a PR when you have the replacement working! If it is useful to you, then I imagine that it is also useful to others in the community 😄

  3. I think so. I tend to take a liberal view on contributions, welcoming most new features here.

@micahstubbs micahstubbs added the question Further information is requested label Jul 18, 2019
@clemarcou
Copy link
Author

Thank you for your answer @micahstubbs.
It probably does date back a lot. I guess I have to try and see for myself if there is any incompatibility.
I'll be sure to submit a pull request when I achieve a satisfying result.
In the mean time, if anyone else has anything to say about such a feature and its implementation, they're very welcome 🤗

@micahstubbs micahstubbs changed the title Why no replacement to Package from CHAP links.Network ? add functionality from CHAP links.Network package Jul 19, 2019
@micahstubbs micahstubbs added the enhancement New feature or request label Jul 19, 2019
@micahstubbs
Copy link
Member

good to hear @clemarcou 😄

I've edited the title of this issue, and will keep it open as a feature request, in case you or another community member wants to add this functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants