New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should we allow directly accessing vis global object? #70

Open

qiankunxie opened this issue Mar 15, 2017 · 0 comments

qiankunxie commented Mar 15, 2017

Currently we need to access vis object from global scope, for angular, should we make a service wrapper for vis object?

        .factory('vis', ['$window', function($window) {
            if (!$window.vis) {
                console.log("error loading library");
                return {};
            }
        	return $window.vis;
        }])

The text was updated successfully, but these errors were encountered:

cdjackson mentioned this issue

Create vis service to avoid directly use vis from window object #71

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment