Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code isn't 64-bit clean #11

Open
ghost opened this issue Mar 4, 2013 · 0 comments
Open

Code isn't 64-bit clean #11

ghost opened this issue Mar 4, 2013 · 0 comments

Comments

@ghost
Copy link

ghost commented Mar 4, 2013

Structs on the Go side use int (which may be 32 or 64 bit depending upon the GOARCH) all over the place when they should use a more specific type.

Eg, in Go ui.Size is defined thusly:

type Size struct {
Width, Height int
}

On the C++ side QSize width and height are also "int", but int in C++ (while this is compiler specific) is generally 32-bits even on 64-bit platforms.

The Go type for Width and Height should be int32, because if it isn't calls that accept an unsafe.Pointer to a ui.Size and expect it to look like a QSize don't even see the height member if linked to a 64-bit build of Qt. This doesn't impact only Size, a lot of Go-side structs in go-ui are similarly mis-declared to use ints in this way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants