Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecated Packages caused by eslint v8.x #794

Open
FakeFriend24 opened this issue Nov 20, 2024 · 4 comments · May be fixed by #806
Open

deprecated Packages caused by eslint v8.x #794

FakeFriend24 opened this issue Nov 20, 2024 · 4 comments · May be fixed by #806

Comments

@FakeFriend24
Copy link

I tried to install vite plugin pwa with npm, but it seems it installs potentially unsafe repositories:

PS path-to-Repo> npm install --save-dev vite-plugin-pwa
npm warn deprecated inflight@1.0.6: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
npm warn deprecated sourcemap-codec@1.4.8: Please use @jridgewell/sourcemap-codec instead
npm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported

after some research i discovered on the vite github a similar issue ( Issue 17306@Vite ) and it seems it is caused by v8.x of eslint depending on a deprecated and unsupported glob which in turn depends on an unsafe inflight.

it seems vite already fixed this with their own upgrade to eslint v9, is there any plans to do so in the near future?

Greetings,
Jey

@mkaurbouvet
Copy link

I'm also getting the same error with eslint v9.

@FakeFriend24
Copy link
Author

@mkaurbouvet do you mean you updated the code base and the requirements to eslint v9 and you still get these error messages?
Could you please elaborate?

@mkaurbouvet
Copy link

@FakeFriend24 I have "eslint": "^9.16.0" installed in the project and there was no issue during npm install. Later I added "vite-plugin-pwa": "^0.21.1", and then npm install started giving deprecated package warning.

npm WARN deprecated inflight@1.0.6: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
npm WARN deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported
npm WARN deprecated sourcemap-codec@1.4.8: Please use @jridgewell/sourcemap-codec instead

@userquin userquin linked a pull request Dec 13, 2024 that will close this issue
@userquin
Copy link
Member

@FakeFriend24 @mkaurbouvet can you check with pkg-pr-new version in linked PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants