Skip to content

Commit 6f88a90

Browse files
authored
perf: lazy load rollup during dev (#15621)
1 parent 93fce55 commit 6f88a90

File tree

3 files changed

+18
-3
lines changed

3 files changed

+18
-3
lines changed

packages/vite/src/node/publicUtils.ts

+7-2
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,18 @@
55
*/
66
export { VERSION as version } from './constants'
77
export { version as esbuildVersion } from 'esbuild'
8-
export { VERSION as rollupVersion } from 'rollup'
98
export {
109
splitVendorChunkPlugin,
1110
splitVendorChunk,
1211
isCSSRequest,
1312
} from './plugins/splitVendorChunk'
14-
export { normalizePath, mergeConfig, mergeAlias, createFilter } from './utils'
13+
export {
14+
normalizePath,
15+
mergeConfig,
16+
mergeAlias,
17+
createFilter,
18+
rollupVersion,
19+
} from './utils'
1520
export { send } from './server/send'
1621
export { createLogger } from './logger'
1722
export { searchForWorkspaceRoot } from './server/searchRoot'

packages/vite/src/node/server/pluginContainer.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ SOFTWARE.
3232
import fs from 'node:fs'
3333
import { join } from 'node:path'
3434
import { performance } from 'node:perf_hooks'
35-
import { VERSION as rollupVersion } from 'rollup'
3635
import { parseAst as rollupParseAst } from 'rollup/parseAst'
3736
import type {
3837
AsyncPluginHooks,
@@ -74,6 +73,7 @@ import {
7473
normalizePath,
7574
numberToPos,
7675
prettifyUrl,
76+
rollupVersion,
7777
timeFrom,
7878
unwrapId,
7979
} from '../utils'

packages/vite/src/node/utils.ts

+10
Original file line numberDiff line numberDiff line change
@@ -162,6 +162,16 @@ export const deepImportRE = /^([^@][^/]*)\/|^(@[^/]+\/[^/]+)\//
162162
// TODO: use import()
163163
const _require = createRequire(import.meta.url)
164164

165+
export function resolveDependencyVersion(
166+
dep: string,
167+
pkgRelativePath = '../../package.json',
168+
): string {
169+
const pkgPath = path.resolve(_require.resolve(dep), pkgRelativePath)
170+
return JSON.parse(fs.readFileSync(pkgPath, 'utf-8')).version
171+
}
172+
173+
export const rollupVersion = resolveDependencyVersion('rollup')
174+
165175
// set in bin/vite.js
166176
const filter = process.env.VITE_DEBUG_FILTER
167177

0 commit comments

Comments
 (0)