fix: support set NODE_ENV in scripts when custom mode option (#8218)

vitejs · May 23, 2022 · adcf041 · adcf041
1 parent fa538cf
commit adcf041
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/packages/vite/src/node/config.ts b/packages/vite/src/node/config.ts
@@ -406,7 +406,9 @@ export async function resolveConfig(
   // Note it is possible for user to have a custom mode, e.g. `staging` where
   // production-like behavior is expected. This is indicated by NODE_ENV=production
   // loaded from `.staging.env` and set by us as VITE_USER_NODE_ENV
-  const isProduction = (process.env.VITE_USER_NODE_ENV || mode) === 'production'
+  const isProduction =
+    (process.env.NODE_ENV || process.env.VITE_USER_NODE_ENV || mode) ===
+    'production'
   if (isProduction) {
     // in case default mode was not production and is overwritten
     process.env.NODE_ENV = 'production'

diff --git a/playground/optimize-deps/vite.config.js b/playground/optimize-deps/vite.config.js
@@ -1,6 +1,9 @@
 const fs = require('fs')
 const vue = require('@vitejs/plugin-vue')
 
+// Overriding the NODE_ENV set by vitest
+process.env.NODE_ENV = ''
+
 /**
  * @type {import('vite').UserConfig}
  */