perf: cache compiled glob for server.fs.deny
#10044
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Splitted
server.fs.deny
part from #10037.This PR makes Vite cache compiled globs. This improved performance for ~4% on my project.
micromatch.isMatch
always callspicomatch(patterns, options)(str)
which leads compiling glob every time.https://github.com/micromatch/micromatch/blob/002d0d184c95e76775528fa1dbe0c446518879b2/index.js#L123
I've changed this to cache
picomatch(patterns, options)
to avoid compiling it.Additional context
Is it safe to rewrite
micromatch
intopicomatch
?picomatch
saysmicromatch
supports more more advanced matching with braces. But actually it currently does not for some functions (micromatch/micromatch#169 (comment)) and as you can see from the implementation I quoted above,micromatch.isMatch
is just a shorthand.Bundle size
Didn't change.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).