-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(plugin-legacy): force set build.target
#10072
Conversation
It is interesting that this wasn't found before, thanks for digging into it Sapphi. |
Co-authored-by: patak <matias.capeletto@gmail.com>
Oh looks like there are conflicts after I approved 😅
I think we should keep them different for now. The modern build target could be changed by #6922 in the future, so I think the difference could be treated as a plugin-legacy feature. |
I think we should keep them different at least until Vite 4. I don't find any big benefits of doing this breaking change in Vite 3.x. |
Let's release this PR in a new minor for plugin-legacy tomorrow. |
Hope #2476 can be fixed to make |
There was a recent change[^1] to `@vitejs/plugin-legacy` that made it hard-code the target to `['es2020', 'edge79', 'firefox67', 'chrome64', 'safari11.1']`. This unfortunately means the build fails if there are any async generators (i.e. `function* foo() {}`). I can't figure out how to make Vite ignore the `ForAwait*.vue` components, so I'll remove the legacy plugin for now. [^1]: [PR](vitejs/vite#10072), [commit](vitejs/vite@a13a7eb)
Description
See #10052 (comment) for reasons.
I'm not sure whether this is a breaking change.
close #10052
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).