feat: align default chunk and asset file names with rollup #10927
Conversation
|
In Astro we override these (even when they mirror Vite's current defaults) so no opinion on this change from our end. I'm not sure what aligning with other tools buy you. Perhaps hosts will use the convention to know if an asset can have an immutable cache header? Although I think some hosts already do this based on what framework outputs, cc @stramel who I think has implemented this in the past. |
|
@matthewp aligning would only make it a bit easier for people to move between rollup, esbuild, and Vite because the defaults are the same. In the sense of least surprise, docs, etc. I think there isn't a technical reason. @benmccann suggested a simplification in vite-plugin-pwa, but this was because the plugin had a regex against the default that has been already corrected by @userquin. |
|
@brc-dd looks like this PR would break VitePress, do you know if you are relying on the format of output files to be |
|
Yeah, there is this line: https://github.com/vuejs/vitepress/blob/cc91d555b5bfcbde35f2ba33aedcd79a5cef713b/src/node/plugin.ts#L18 I'll explicitly add |
You can just change it to support both formats: PWA plugin Will use this approach. VitePress will need some changes if you want to align it with Vite: |
|
Supporting both isn't a bad idea for the moment, but it would be better to check how to avoid depending on the format because the user can change it. IIUC, VitePress doesn't prevent that, no? |
There are many places where we are relying on that format. For example, in client, the requests are made according to that format. Supporting both will likely get messy (as the client guesses the chunk name from hash).
Never tested. Also, I don't know why anyone would do that. Moreover, if the vite config is added through .vitepress/config.ts, then we are simply overriding those values. |
|
@patak-dev bump vp's version, it should work now. |
|
Thanks @brc-dd! |
|
We discussed this PR in today's team meeting and we think it is a good idea to move forward with it. |
Per vitejs/vite#10927, there was a change made as part of vite 4 to align default build file names with the default from rollup. While this is mostly superficial for us, since the change causes a slight difference in the production filename artifact I'm explicitly adding a configuration for it.
Description
Both rollup and esbuild use
[name]-[hash].[extname]for their default chunk and asset file names. In Vite the default is[name].[hash].[extname](for historical reasons according to Evan)I think we should use the opportunity of Vite 4 to align with the closest tools in the ecosystem. @benmccann and @danielroe already said this would be fine with them. @matthewp @bluwy interested to know Astro's position. Given that
assetFileNamesandchunkFileNamesare configurable, the ecosystem shouldn't be relying on our defaults, but there may be CI tests failures if there are regexes against the default like we had in Vite (cc @dominikg)What is the purpose of this pull request?