Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(worker): disable build reporter plugin when bundling worker #11058

Merged
merged 1 commit into from
Nov 24, 2022

Conversation

sapphi-red
Copy link
Member

Description

When running pnpm build in playground/worker, the log was like:

vite v4.0.0-alpha.5 building for production...
✓ 1 modules transformed.
✓ 2 modules transformed.
✓ 3 modules transformed.
✓ 4 modules transformed.
✓ 5 modules transformed.
✓ 7 modules transformed.
✓ 11 modules transformed.
✓ 12 modules transformed.
✓ 17 modules transformed.
✓ 18 modules transformed.
✓ 25 modules transformed.
✓ 32 modules transformed.
✓ 33 modules transformed.
✓ 34 modules transformed.
✓ 16 modules transformed.

This PR fixes this output to be:

vite v4.0.0-alpha.5 building for production...
✓ 16 modules transformed.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added p2-nice-to-have Not breaking anything but nice to have (priority) feat: web workers labels Nov 24, 2022
@patak-dev patak-dev merged commit 7b72069 into vitejs:main Nov 24, 2022
@sapphi-red sapphi-red deleted the fix/disable-worker-reporter branch November 24, 2022 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: web workers p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants