Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(esbuild): add test for configuration overrides #11267

Merged
merged 4 commits into from
Dec 10, 2022
Merged

chore(esbuild): add test for configuration overrides #11267

merged 4 commits into from
Dec 10, 2022

Conversation

high1
Copy link
Contributor

@high1 high1 commented Dec 8, 2022 •
edited
Loading

Description

Tests for esbuild plugin, #11049 was merged without these

Additional context

Make sure that specific esbuild options, if specified, correctly override typescript configuration ones.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@high1
Copy link
Contributor Author

high1 commented Dec 8, 2022 •
edited
Loading

@sapphi-red let me know if these tests are enough to cover #11049.

sapphi-red
sapphi-red approved these changes Dec 10, 2022
View reviewed changes
Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sapphi-red sapphi-red added test p1-chore Doesn't change code behavior (priority) labels Dec 10, 2022
@bluwy bluwy changed the title chore: added test for configuration overrides chore(esbuild): add test for configuration overrides Dec 10, 2022
@bluwy bluwy merged commit f897b64 into vitejs:main Dec 10, 2022
futurGH pushed a commit to futurGH/vite that referenced this pull request Feb 26, 2023
@high1 @futurGH
chore(esbuild): add test for configuration overrides (vitejs#11267)
762c502
@sapphi-red sapphi-red mentioned this pull request Jun 15, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sapphi-red sapphi-red sapphi-red approved these changes

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
p1-chore Doesn't change code behavior (priority) test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@high1 @bluwy @sapphi-red