-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: wrongly resolve to optimized doppelganger #11290
Conversation
I think the wrong result is return by this line. It return the optimized bundle without checking whether it is resolveable from the |
I just push a commit to fix it. |
/ecosystem-ci run |
📝 Ran ecosystem CI: Open
|
/ecosystem-ci run nuxt-framework |
📝 Ran ecosystem CI: Open
|
/ecosystem-ci run sveltekit |
/ecosystem-ci run sveltekit |
This reverts commit 34fec41.
This is reworked in #11410 |
Description
This PR fix a bug:
when a dependency has a doppelganger (duplicate package with same name but different version), and one of it is optimized, then some dependents of the package wrongly get the optimized version(expect unoptimized version).
Example:
When
test-package-a
importtest-package-b
, it expectstest-package-b@2.0.0
. But it actually gettest-package-b@1.0.0
(the optimized bundle).It should resolve to the nested dependency, instead of the optimized doppelganger.
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).