fix: revert #11290 #11412
Merged
fix: revert #11290 #11412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 34fec41.
|
/ecosystem-ci run |
|
📝 Ran ecosystem CI: Open
|
bluwy
approved these changes
Dec 18, 2022
|
Ladle and Histoire are also failing now on both 4.0.1 and on main, see https://discord.com/channels/804011606160703521/928398470086291456/1053980152461262899 Merging and releasing 4.0.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reverts commit 34fec41:
See context:
There is already work ongoing to fix the new bug at #11410 by @csr632, but it is safer we revert until that is ironed out. @csr632 I think you could add back the tests I'm reverting here to #11410 together with new tests for the bug discovered by the Solid folks.
What is the purpose of this pull request?