feat: support rollup plugin this.load in plugin container context #11469
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds support for calling this.load (added in Rollup 2.60) in a rollup plugin when using a plugin context via Vite's plugin container (namely, when using the dev server).
Resolves #6810
Additional context
This fixes the issue I have in my specific use case (rollup-plugin-typescript2 needing to call this.load, though not using any of its output - I tested this PR locally with that test case), and is strictly more functional than the previous lack of support. However, there are some limitations which I don't know if it's appropriate to address or otherwise present issues:
this.load
from Vite will be a ModuleInfoProxy, which doesn't include most of the properties from ModuleInfo. I imagine some plugins are likely to be callingthis.load
expecting some of these parameters to work. That said, this is already an existing limitation of getModuleInfo, so I assume that is out of scope.this.load
is supposed to triggertransform
andmoduleParsed
- this does not (in accordance with vite's on-demand nature)I don't have much experience working at this level, so feedback is definitely appreciated, and I'm happy to make any adjustments
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).