Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support BROWSER and BROWSER_ARGS in env file #11513

Merged
merged 2 commits into from
Jan 4, 2023
Merged

feat: support BROWSER and BROWSER_ARGS in env file #11513

merged 2 commits into from
Jan 4, 2023

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Dec 28, 2022

Description

close #7329
close #9557

Support passing browser args through process.env.BROWSER_ARGS, similar to CRA.

Support BROWSER and BROWSER_ARGS configuration in .env files as convenience. This could be a breaking change for users who set this for some specific configuration, but I don't think there's a significant impact in practice.

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added the p2-nice-to-have Not breaking anything but nice to have (priority) label Dec 28, 2022
sapphi-red
sapphi-red approved these changes Dec 31, 2022
View reviewed changes
Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this on Windows and worked fine 💯

patak-dev
patak-dev approved these changes Jan 3, 2023
View reviewed changes
Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! I think this is an uncontroversial addition. Let's merge it for the 4.1 beta.

@patak-dev patak-dev added this to the 4.1 milestone Jan 3, 2023
@patak-dev patak-dev merged commit 8972868 into main Jan 4, 2023
@patak-dev patak-dev deleted the feat-browser-env-args branch January 4, 2023 16:08
futurGH pushed a commit to futurGH/vite that referenced this pull request Feb 26, 2023
@bluwy @futurGH
feat: support BROWSER and BROWSER_ARGS in env file (vitejs#11513)
b7a8b1d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mominshaikhdevs mominshaikhdevs mominshaikhdevs approved these changes

@sapphi-red sapphi-red sapphi-red approved these changes

@patak-dev patak-dev patak-dev approved these changes

Assignees
No one assigned
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Milestone
4.1
4 participants
@bluwy @patak-dev @sapphi-red @mominshaikhdevs