fix: two folders are created when the project name contains spaces

[btea]

Description

When select customize with create-vue, If the project name contains a space, two folders will be created, and then the template content will be filled into the folder named with the character before the first space.

Additional context

---

What is the purpose of this pull request?

• Bug fix
• New Feature
• Documentation update
• Other

Before submitting the PR, please make sure you do the following

• Read the Contributing Guidelines.
• Read the Pull Request Guidelines and follow the PR Title Convention.
• Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
• Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
• Ideally, include relevant tests that fail without this PR but pass with it.

[sapphi-red]

I think simply replacing args instead of replacing the fullCustomCommand would be more easy to understand.

// we replace TARGET_DIR here because targetDir may include a space
let replacedArgs = args.map(arg => arg.replace('TARGET_DIR', targetDir))

Would you also add a test here?
https://github.com/vitejs/vite/blob/main/packages/create-vite/__tests__/cli.spec.ts

[btea]

The code has been updated, but there seems to be something wrong with my device, could you help to add a test?

[btea]

When I add the test, I found that if projectName contains spaces, the value received by progress.argv will be split. Therefore, targetDir can only get the characters before the spaces. How to deal with this scense? 🤔

[sapphi-red]

In that case, I think the user should quote the project name (e.g. npm init vite@latest "project name with spaces").

[btea]

Yes, However, when executing pnpm create vite, the input Project name may contain spaces. I think that after the template is created, if the project name contains spaces, the project name should be wrapped in quotes in the cd projectName output from the terminal.

[sapphi-red]

So you're suggest updating this line? I think that makes sense.

vite/packages/create-vite/src/index.ts

Line 381 in 697dd00

console.log(` cd ${path.relative(cwd, root)}`)

[btea]

Yes, I think it should be updated here. And the previous modification is also necessary. But I don't know how to write this test case?

[sapphi-red]

I tried writing the test but it seems to be quite complex. I think we can go without tests.

If we replace this execaCommandSync with execaSync, we can test the case of passing the project name from argv.

vite/packages/create-vite/__tests__/cli.spec.ts

Line 16 in 2ff5930

return execaCommandSync(`node ${CLI_PATH} ${args.join(' ')}`, options)

But for the case of typing the project name, we need to feed the text from stdin and the test seems to hang.