Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: narrow defineConfig return type #12021

Merged
merged 1 commit into from
Feb 14, 2023
Merged

Conversation

fi3ework
Copy link
Member

@fi3ework fi3ework commented Feb 10, 2023

Description

Since defineConfig return an as-is input value and type. We could leverage TS overloading to narrow the returned type as the input type. It will be very useful especially deconstructing a return value from defineConfig and reusing it in another defineConfig.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After further thought, I think this is good instead of a generic so that the allowed types are stricter.

@bluwy bluwy added the p3-minor-bug An edge case that only affects very specific usage (priority) label Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants