Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-legacy): no build.target override on SSR build #12171

Merged
merged 2 commits into from
Mar 1, 2023

Conversation

Tal500
Copy link
Contributor

@Tal500 Tal500 commented Feb 23, 2023

This very simple PR avoid the plugin-legacy overriding (and warning if exists) of the build.target configuration for SSR.

Sadly, in plugin-legacy, the build.target overriding (and warning if exists) happen on SSR build as well.

In addition, some other plugins, like SvelteKit (together with my legacy support PR there - sveltejs/kit#6265), automatically "fixes" the build target for the SSR build, so this will eliminate the warning we get there as a side effect.


What is the purpose of this pull request?

  • Bug fix

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy changed the title fix: no build.target override on SSR build fix(plugin-legacy): no build.target override on SSR build Feb 25, 2023
@bluwy bluwy added plugin: legacy p3-minor-bug An edge case that only affects very specific usage (priority) labels Feb 25, 2023
Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
@bluwy bluwy merged commit a1019f8 into vitejs:main Mar 1, 2023
@Tal500 Tal500 deleted the no-legacy-target-override-on-ssr branch March 1, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority) plugin: legacy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants