Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(define): correctly replace SSR in dev #12204

Merged
merged 3 commits into from
Mar 8, 2023
Merged

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Feb 26, 2023

Description

In dev, the define plugin replaces import.meta.env.SSR with config.build.ssr. It should be based on the plugin ssr option instead to be accurate. This PR fixes that.

Additional context

I refactored the __vite__* naming a bit so it looks nicer 😬


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added the p3-minor-bug An edge case that only affects very specific usage (priority) label Feb 26, 2023
@patak-dev patak-dev merged commit 0f6de4d into main Mar 8, 2023
@patak-dev patak-dev deleted the fix-define-ssr-replace branch March 8, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants