Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(resolve): remove deep import syntax handling #12381

Merged
merged 6 commits into from
Mar 14, 2023
Merged

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Mar 12, 2023

Description

Remove foo > bar import handling in tryNodeResolve. This syntax is unique to optimizeDeps.include only, so this PR moves the handling there.

This doesn't improve performance (maybe a tiny bit), but it should make the code more readable.

Additional context

This non-standard stuff was added in one of my first PRs 😬 Time to clean it up.

Existing tests should pass. Running vite-plugin-svelte's test should help too, although we only have one test that covers this, as the plugin had moved to an esbuild plugin approach.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added the p2-nice-to-have Not breaking anything but nice to have (priority) label Mar 12, 2023
@stackblitz
Copy link

stackblitz bot commented Mar 12, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Co-authored-by: 翠 / green <green@sapphi.red>
@bluwy bluwy merged commit 42e0d6a into main Mar 14, 2023
@bluwy bluwy deleted the refactor-deep-syntax branch March 14, 2023 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants